Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mounting app component with props #567

Merged
merged 3 commits into from
Aug 10, 2019
Merged

Allow mounting app component with props #567

merged 3 commits into from
Aug 10, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Aug 8, 2019 •
edited
Loading

  • The pre-existing app mount methods have all been moved to an impl block with Default bounds on Component::Properties
  • New mount methods have been added without those bounds and allow passing in props to the app on mount

Fixes: #566

totorigolo
totorigolo reviewed Aug 9, 2019
View reviewed changes
src/lib.rs Show resolved Hide resolved
@jstarry jstarry merged commit c3d270c into yewstack:master Aug 10, 2019
@jstarry jstarry deleted the mount-with-props branch August 10, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totorigolo totorigolo totorigolo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App root component should not be forced to have a Properties type of ()
2 participants
@jstarry @totorigolo